Make S3 private storage ignore problematic AWS_S3_CUSTOM_DOMAIN setting
#24
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the private storage class always ignores the optional Boto setting `AWS_S3_CUSTOM_DOMAIN`. Without this hack, when that setting is applied it affects all storage classes and causes them to generate URLs to S3 objects with the given domain and *without* any request signing, producing invalid URLs for private objects. See related commit for RFDS in amongst the long issue #193: https://github.com/ixc/rfds/commit/a14b0748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the private storage class always ignores the optional Boto
setting
AWS_S3_CUSTOM_DOMAIN.Without this hack, when that setting is applied it affects all
storage classes and causes them to generate URLs to S3 objects with
the given domain and without any request signing, producing invalid
URLs for private objects.
See related commit for RFDS in amongst the long issue #193:
https://github.com/ixc/rfds/commit/a14b0748